This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patch, libstdc++] fix TCL error in abi.exp


On 05/16/14 13:53, Sandra Loosemore wrote:
As noted in PR 23867, the libstdc++ ABI testsuite doesn't work for
installed compiler testing.  There is some logic in abi.exp to check for
the presence of the required bits and skip these tests if they're not
there, but before it gets that far it's hitting a TCL error:

ERROR: can't read "baseline_subdir_switch": no such variable
     while executing
"eval exec $cxx $baseline_subdir_switch"
     invoked from within
"set baseline_subdir "[eval exec $cxx $baseline_subdir_switch]""
...

This patch moves the offending reference to $baseline_subdir_switch
after the check for missing bits instead of before.  OK to commit?

-Sandra


2014-05-16  Iain Sandoe  <iain@codesourcery.com>
         Sandra Loosemore  <sandra@codesourcery.com>

         libstdc++-v3/
         * testsuite/libstdc++-abi/abi.exp: Defer setting of
baseline_subdir
         until after checking that the test is eligible to be run.
OK.
Jeff


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]