This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH][ARM][committed] Use enum name for PARAM_SCHED_PRESSURE_ALGORITHM


Now with patch attached.

Also forgot to mention.
Tested arm-none-eabi.

Kyrill

On 15/05/14 12:25, Kyrill Tkachov wrote:
Hi all,

The scheduler algorithms are defined in sched-int.h as:
enum sched_pressure_algorithm
{
    SCHED_PRESSURE_NONE,
    SCHED_PRESSURE_WEIGHTED,
    SCHED_PRESSURE_MODEL
};
We should use the enum name SCHED_PRESSURE_MODEL rather than the direct integer
value (2).

This doesn't make any functional difference, just makes it a bit more readable
(and avoids any unexpected effects in the future if enum
sched_pressure_algorithm is extended).

Committed as obvious with r210471.

Cheers,
Kyrill

2014-05-15  Kyrylo Tkachov  <kyrylo.tkachov@arm.com>

      * config/arm/arm.c (arm_option_override): Use the SCHED_PRESSURE_MODEL
      enum name for PARAM_SCHED_PRESSURE_ALGORITHM.


diff --git a/gcc/config/arm/arm.c b/gcc/config/arm/arm.c
index 28b6b29..14e86c3 100644
--- a/gcc/config/arm/arm.c
+++ b/gcc/config/arm/arm.c
@@ -50,6 +50,7 @@
 #include "except.h"
 #include "tm_p.h"
 #include "target.h"
+#include "sched-int.h"
 #include "target-def.h"
 #include "debug.h"
 #include "langhooks.h"
@@ -2944,7 +2945,7 @@ arm_option_override (void)
      prefer_neon_for_64bits = true;
 
   /* Use the alternative scheduling-pressure algorithm by default.  */
-  maybe_set_param_value (PARAM_SCHED_PRESSURE_ALGORITHM, 2,
+  maybe_set_param_value (PARAM_SCHED_PRESSURE_ALGORITHM, SCHED_PRESSURE_MODEL,
                          global_options.x_param_values,
                          global_options_set.x_param_values);
 

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]