Re: [patch, mips] delete bit-rotten ADJUST_REG_ALLOC_ORDER definition

[Sandra Loosemore <sandra at codesourcery dot com>]

On 05/14/2014 12:49 PM, Richard Sandiford wrote:
> Jeff Law <law@redhat.com> writes:
> > On 05/13/14 14:11, Sandra Loosemore wrote:
> > > 2014-05-13  Catherine Moore  <clm@codesourcery.com>
> > >           Sandra Loosemore  <sandra@codesourcery.com>
> > >
> > >       gcc/
> > >       * config/mips/mips.c (mips_order_regs_for_local_alloc): Delete.
> > >       * config/mips/mips.h (ADJUST_REG_ALLOC_ORDER): Delete.
> > >       * config/mips/mips-protos.h (mips_order_regs_for_local_alloc): Delete.
> > OK for the trunk.
>
> Would it be OK to hold off until after the switch to LRA?  That patch
> has been written and the MIPS parts approved, but we're waiting for
> some legal things to be sorted out and for a fixed version of the LRA
> EXTRA_MEMORY_CONSTRAINT patch.  I just think it'd be better to tune this
> sort of thing once that's done, rather than tune it against reload.

Yeah, sure -- I think we're all in agreement that the current code needs 
to go, but re-benchmarking would be a good thing.

> FWIW here's an old patch I had lying around.  I wasn't happy with
> the results for CSiBE at the time but maybe it'd be worth looking
> at it again after LRA.  E.g., we might want to put the non-MIPS16
> call-clobbered GPRs ahead of the MIPS16 ones, so that when we're
> looking for any old GPR, we only pick a MIPS16 register if no
> others are free.

FWIW, I think that just messing with REG_ALLOC_ORDER directly, as this 
patch does, is a better approach for tuning anyway than the 
ADJUST_REG_ALLOC_ORDER hook.

-Sandra