This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [google gcc-4_8] LIPO: check the incompatibility of use and saved command line


Ok. For non-autofdo path, I think a warning (even an error) is needed
in case of mismatch.

David

On Mon, May 12, 2014 at 4:35 PM, Rong Xu <xur@google.com> wrote:
> Hi,
>
> This patch adds an extra check of the incompatibility of use and saved
> command line for the primary module. If the check files, we skip the
> inclusion of all aux modules.
> Maybe we should check the aux module command line with the
> use-compilation command line directly. But I keep the old way that
> checks b/w saved command lines.
>
> Tested with the program exposed this issue and internal benchmarks.
> This check never failed for instrumentation based lipo in the test.
>
> Thanks,
>
> -Rong


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]