This is the mail archive of the
mailing list for the GCC project.
Re: [patch] fix impliedness of -Wunused-parameter depending on -Wexta option ordering
- From: "Joseph S. Myers" <joseph at codesourcery dot com>
- To: Matthias Klose <doko at ubuntu dot com>
- Cc: GCC Patches <gcc-patches at gcc dot gnu dot org>, Manuel López-Ibáñez <lopezibanez at gmail dot com>
- Date: Mon, 12 May 2014 17:30:00 +0000
- Subject: Re: [patch] fix impliedness of -Wunused-parameter depending on -Wexta option ordering
- Authentication-results: sourceware.org; auth=none
- References: <536BF4F1 dot 8020402 at ubuntu dot com> <Pine dot LNX dot 4 dot 64 dot 1405082136500 dot 12485 at digraph dot polyomino dot org dot uk> <5370F366 dot 80300 at ubuntu dot com>
On Mon, 12 May 2014, Matthias Klose wrote:
> I didn't look close enough to the gfortran test results. PR driver/61126 is a
> fix for the regression introduced with the fix for the above issue. With this
> patch proposed by Manuel, gfortran.dg/wextra_1.f now passes, and no new
> regressions seen on the trunk and the branches.
I think changing the order of the handlers has far too high a risk of
introducing further nonobvious regressions to consider it for the
branches. You need a clear and careful analysis of the circumstances
under which the order of the handlers can affect observable compiler
behavior in order to justify such a change as safe. But I think a better
principle is that if the order matters, there is a bug in those handlers
and they should be fixed so that the order doesn't matter (absent a clear
design showing why it is desirable for the order to matter).
Joseph S. Myers