This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH 5/7] Shrink SCRATCH

From: Jeff Law <law at redhat dot com>
To: gcc-patches at gcc dot gnu dot org, rdsandiford at googlemail dot com
Date: Mon, 12 May 2014 10:00:52 -0600
Subject: Re: [PATCH 5/7] Shrink SCRATCH
Authentication-results: sourceware.org; auth=none
References: <87a9ap1k8n dot fsf at talisman dot default> <87oaz5z8w5 dot fsf at talisman dot default>

On 05/10/14 14:16, Richard Sandiford wrote:

SCRATCH has a single "0" field because reload used to turn it directly
into a REG.  It no longer does (or could do) that since REG has three
fields rather than one.  This patch therefore updates the comment and
removes the field.

Tested on x86_64-linux-gnu.  OK to install?

Thanks,
Richard


gcc/
	* rtl.def (scratch): Fix outdated comment and remove "0" field.
	* gengtype.c (adjust_field_rtx_def): Update accordingly.

Are you sure reload doesn't still do this? Do you have a pointer towhen this code was removed?

While I would have expected something to break, perhaps the problems arejust latent.

If you had a pointer which showed this code in reload being removed, I'dapprove without hesitation.


Jeff

Follow-Ups:
- Re: [PATCH 5/7] Shrink SCRATCH
  - From: Richard Sandiford

References:
- [PATCH 0/7] Shrink some rtxes
  - From: Richard Sandiford
- [PATCH 5/7] Shrink SCRATCH
  - From: Richard Sandiford

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]