This is the mail archive of the mailing list for the GCC project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [C PATCH] Make attributes accept enum values (PR c/50459)

Marek Polacek <> writes:

> On Sun, May 11, 2014 at 09:18:47PM +0200, Rainer Orth wrote:
>> No, that's wrong: avoid hardcoding target lists if at all possible.
>> Besides, it's wrong since it doesn't cover the Solaris (and other
>> non-gld linker) case.  Use the init_priority effective-target keyword
>> instead.  Also, please check if you can use dg-xfail-if instead: if
>> anything changes, the test turns into an XPASS instead of the change
>> going unnoticed with dg-skip-if.
> I don't see tests using dg-skip-if and init_priority, so this patch

No need for examples: as you can see in doc/sourcebuild.texi, both dg-do
and dg-skip-if accept the same selectors.

> does what we do for other tests using cdtor priorities.
> 2014-05-11  Marek Polacek  <>
> 	* c-c++-common/pr50459.c: Require init_priority target.



Rainer Orth, Center for Biotechnology, Bielefeld University

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]