This is the mail archive of the
mailing list for the GCC project.
Re: [PATCH 1/7] Fix GTY markup of u2
- From: Richard Sandiford <rdsandiford at googlemail dot com>
- To: Michael Matz <matz at suse dot de>
- Cc: Mike Stump <mikestump at comcast dot net>, gcc-patches at gcc dot gnu dot org
- Date: Mon, 12 May 2014 11:53:59 +0100
- Subject: Re: [PATCH 1/7] Fix GTY markup of u2
- Authentication-results: sourceware.org; auth=none
- References: <87a9ap1k8n dot fsf at talisman dot default> <8761ld1k4o dot fsf at talisman dot default> <E5677A80-2E13-420C-B0DF-C098469B1789 at comcast dot net> <alpine dot LNX dot 2 dot 00 dot 1405121213310 dot 23942 at wotan dot suse dot de>
Michael Matz <firstname.lastname@example.org> writes:
> On Sat, 10 May 2014, Mike Stump wrote:
>> > The rtx u2 field currently uses a desc/tag pair for GTY. This seems
>> > unnecessary though,
>> > OK to install?
>> Ick. I donât favor skip. The change feels like a premature
>> optimization that doesnât net any code gen benefit. Iâll defer to a gty
>> person if they prefer skip.
> The skip is necessary, otherwise union members of GTY structs are required
> to have a 'desc' (and their members in turn are required to have a 'tag').
> So it's either the skip or the desc/tag pair. The code-gen difference is
> one empty (but two-cased) switch statement less.
Yeah, but the reason I'm removing the desc/tag pair isn't so much to get
rid of that (the compiler should do it for us) but because marking it
anything other than "skip" gives the impression that we want to allow
GC pointers in the union.