This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Fix uninitialised variable warning in tree-ssa-loop-ivcanon.c


On 04/17/14 10:43, Kyrill Tkachov wrote:
Hi all,

While looking at the build logs I noticed a warning while building
tree-ssa-loop-ivcanon.c about a potential use of an uninitialised variable.
This patchlet fixes that warning by initialising it to 0.

Tested arm-none-eabi.

Ok for trunk?

2014-04-17  Kyrylo Tkachov  <kyrylo.tkachov@arm.com>

     * tree-ssa-loop-ivcanon.c (canonicalize_loop_induction_variables):
     Initialise n_unroll to 0.
So did you do a thorough analysis to verify that it was a false positive or that it was a valid warning?

For the former, it would be helpful if you filed a BZ. We track these false positives for -Wuninitialized and do try to correct them. If the latter then is using 0 for the initializer the safe thing to do?

Jeff


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]