This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Fix cgraph dumping bug
- From: Richard Biener <richard dot guenther at gmail dot com>
- To: Teresa Johnson <tejohnson at google dot com>,"gcc-patches at gcc dot gnu dot org" <gcc-patches at gcc dot gnu dot org>,Jan Hubicka <hubicka at ucw dot cz>
- Cc: David Li <davidxl at google dot com>
- Date: Fri, 09 May 2014 19:49:59 +0200
- Subject: Re: [PATCH] Fix cgraph dumping bug
- Authentication-results: sourceware.org; auth=none
- References: <CAAe5K+X3VJZDc7Ru4Y30c=m_NnBLOC_OzYPLYxhaxavkQB3GMw at mail dot gmail dot com>
On May 9, 2014 5:53:06 PM CEST, Teresa Johnson <tejohnson@google.com> wrote:
>Fixed a place where the wrong dump file was being used, leading to
>an inconsistency and seg fault when dump_file was non-NULL but
>cgraph_dump_file was NULL.
>
>Bootstrapped and tested on x86-64-unknown-linux-gnu. Ok for trunk?
OK.
Thanks,
Richard.
>Thanks,
>Teresa
>
>2014-05-09 Teresa Johnson <tejohnson@google.com>
>
> * cgraphunit.c (analyze_functions): Use correct dump file.
>
>Index: cgraphunit.c
>===================================================================
>--- cgraphunit.c (revision 210157)
>+++ cgraphunit.c (working copy)
>@@ -984,7 +984,7 @@ analyze_functions (void)
> first_analyzed_var = varpool_first_variable ();
> first_analyzed = cgraph_first_function ();
>
>- if (changed && dump_file)
>+ if (changed && cgraph_dump_file)
> fprintf (cgraph_dump_file, "\n");
>
> /* Lower representation, build callgraph edges and references
>for all trivially