This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: Fix PR ipa/60965 (placement new wrt ipa-devirt)
- From: Paolo Carlini <paolo dot carlini at oracle dot com>
- To: Jan Hubicka <hubicka at ucw dot cz>, gcc-patches at gcc dot gnu dot org
- Date: Wed, 07 May 2014 00:40:58 +0200
- Subject: Re: Fix PR ipa/60965 (placement new wrt ipa-devirt)
- Authentication-results: sourceware.org; auth=none
- References: <20140505194438 dot GB26890 at kam dot mff dot cuni dot cz>
Hi Honza,
On 05/05/2014 09:44 PM, Jan Hubicka wrote:
Hi,
this patch fixes unfortunate thinko in get_class_context that invalidates
transitions from non-POD type to a polymorphic type that may happen by virtue
of placement new and apparently breaks openJDK and Qt. I really tried to keep
placement new in mind when implementing ipa-devirt, so hope there are no
similar negaitve surprises.
The patch disables about 200 out of 30000 devirtualizations happening in
Firefox.
I have commited it to 4.9 and will commit to mainline once testing finishes.
Honza
PR ipa/60965
* g++.dg/ipa/devirt-31.C: New testcase.
* g++.dg/ipa/devirt-11.C: Adjust testcase.
Does devirt-11.C require further adjustment in the branch? Apparently it
is failing, eg:
http://gcc.gnu.org/ml/gcc-testresults/2014-05/msg00383.html
and for me too ;)
Thanks,
Paolo.