This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH 1/2] teach mklog to get name / email from git config when available
- From: Segher Boessenkool <segher at kernel dot crashing dot org>
- To: Trevor Saunders <tsaunders at mozilla dot com>
- Cc: gcc-patches at gcc dot gnu dot org, dnovillo at google dot com, Trevor Saunders <tbsaunde at mozilla dot com>
- Date: Tue, 29 Apr 2014 17:54:12 -0500
- Subject: Re: [PATCH 1/2] teach mklog to get name / email from git config when available
- Authentication-results: sourceware.org; auth=none
- References: <1398737468-6981-1-git-send-email-tsaunders at mozilla dot com> <1398737468-6981-2-git-send-email-tsaunders at mozilla dot com> <20140429153900 dot GA3930 at gate dot crashing dot org> <20140429174138 dot GA27090 at tsaunders-iceball dot corp dot tor1 dot mozilla dot com>
> > > +if (-d .git) {
> > "-d .git" is, erm, not so great.
>
> yeah, the only reason I was willing to do it is the script already
> requires being run at top level, but that annoys me too.
That, but also it is equivalent to
if ((-d $_)."git") {
which is probably not what you wanted ;-)
"use warnings" complains loudly and "use strict" plain refuses to
compile this.
> > How about something like
>
> It has the same issue that it'll activate ina svn checkout if you have
> git configured, but I'm not sure that's a case worth caring about.
If you have configured your name and email for git (for this repo or
globally) it probably is the name/email you want to use, better than
the finger output (but an override might be handy, dunno).
Segher