Re: [PATCH 2/2] allow running mklog as a filter

[Trevor Saunders <tsaunders at mozilla dot com>]

On Tue, Apr 29, 2014 at 09:18:39AM +0400, Yury Gribov wrote:
> >+# XXX We should probably accept /dev/stdin or maybe magic autodetection of
> >+# being supposed to get the patch from stdin.
> >+#
> 
> Can we just set $diff to '-' if @ARGV is empty?

sgtm

> >+# In any case if we got the diff on stdin then write the ChangeLog to stdout.
> 
> Hm, this is breaks semantics: you only dump CL instead of CL+diff just
> because diff comes from stdin. Perhaps we could append contents of
> @diff_lines here?

 I agree stdin gets different semantics than other files but I think
 that's sort of ok because it means you generated the patch somehow so
 presumably you can do that again if you need the patch.  Writing the
 diff to stdout seems possible, but atleast for my use cases its
 annoying, but I guess I'm open to adding a flag or something.

> >+if ($diff == "-") {
> 
> This will work but 'eq' is preferred way to compare strings.

oh perl

Trev

> 
> -Y

Attachment: signature.asc
Description: Digital signature