This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH 2/2] allow running mklog as a filter
- From: Yury Gribov <y dot gribov at samsung dot com>
- To: tsaunders at mozilla dot com, gcc-patches at gcc dot gnu dot org
- Cc: dnovillo at google dot com, Trevor Saunders <tbsaunde at mozilla dot com>
- Date: Tue, 29 Apr 2014 09:18:39 +0400
- Subject: Re: [PATCH 2/2] allow running mklog as a filter
- Authentication-results: sourceware.org; auth=none
- References: <1398737468-6981-1-git-send-email-tsaunders at mozilla dot com> <1398737468-6981-3-git-send-email-tsaunders at mozilla dot com>
+# XXX We should probably accept /dev/stdin or maybe magic autodetection of
+# being supposed to get the patch from stdin.
+#
Can we just set $diff to '-' if @ARGV is empty?
+# In any case if we got the diff on stdin then write the ChangeLog to stdout.
Hm, this is breaks semantics: you only dump CL instead of CL+diff just
because diff comes from stdin. Perhaps we could append contents of
@diff_lines here?
+if ($diff == "-") {
This will work but 'eq' is preferred way to compare strings.
-Y