This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] PR60822 (m68k, missing earlyclobber in extendplussidi)


On 04/16/14 18:20, segher@kernel.crashing.org wrote:
On Wed, Apr 16, 2014 at 02:45:28PM -0600, Jeff Law wrote:
Isn't the problem that operands 1 is a MEM which use the same register
as operands 3 in the memory address?

Yes, exactly.

ISTM either removing the memory constraint entirely, or splitting it off
into a separate alternative and only earlyclobbering that alternative
would be better.

Or am I missing something?

No, that does seem better :-)

I tried both your suggestions; the first results in better code.  Here's
a new patch.  As before, it builds and fixes the testcase, but I didn't
run the testsuite (I have no emulator set up).

Thanks,


Segher



gcc/

PR target/60822
2014-04-16  Segher Boessenkool  <segher@kernel.crashing.org>

	* config/m68k/m68k.md (extendplussidi): Don't allow memory for
	operand 1.
Thanks. I tweaked the comment and added the testcase to the regression suite and installed the fix on the trunk.

Jeff


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]