This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH 3/3] [LLVM] [sanitizer] add conditionals for libc
- From: Konstantin Serebryany <konstantin dot s dot serebryany at gmail dot com>
- To: Bernhard Reutner-Fischer <rep dot dot dot nop at gmail dot com>
- Cc: Jakub Jelinek <jakub at redhat dot com>, GCC Patches <gcc-patches at gcc dot gnu dot org>, Dodji Seketeli <dodji at redhat dot com>, Kostya Serebryany <kcc at google dot com>, Dmitry Vyukov <dvyukov at google dot com>, llvm-commits at cs dot uiuc dot edu
- Date: Wed, 23 Apr 2014 12:58:22 +0400
- Subject: Re: [PATCH 3/3] [LLVM] [sanitizer] add conditionals for libc
- Authentication-results: sourceware.org; auth=none
- References: <20130405094956 dot GB20334 at tucnak dot redhat dot com> <1397742577-22841-1-git-send-email-rep dot dot dot nop at gmail dot com> <1397742577-22841-4-git-send-email-rep dot dot dot nop at gmail dot com> <CAGQ9bdxpfnbN93jiBSoGyTw_w4gxuSfbXYxebyp5DSO351avuw at mail dot gmail dot com> <CAC1BbcSYPQ_oDmRbNHnhWuxKOzN_zs1q7bEXR0_DKyXqjcVikw at mail dot gmail dot com> <CAGQ9bdxUyFAY2VQofW=+EurWHHxREezGsSfhyWH69f6_y3p56w at mail dot gmail dot com> <145709364d8 dot 2760 dot 0f39ed3bcad52ef2c88c90062b7714dc at gmail dot com> <CAGQ9bdy77gSxDwRphZhj6vZL8nCoSgYxPisV_7Ub-fy2_mw9Rg at mail dot gmail dot com> <CAC1BbcRAQgG2ZYeEPZvqKboJcSb4gCLTdL17Wat-BPGnRdovYQ at mail dot gmail dot com>
Thanks. Let's move the discussion there.
On Wed, Apr 23, 2014 at 12:46 PM, Bernhard Reutner-Fischer
<rep.dot.nop@gmail.com> wrote:
> On 17 April 2014 19:01, Konstantin Serebryany
> <konstantin.s.serebryany@gmail.com> wrote:
>> On Thu, Apr 17, 2014 at 8:45 PM, Bernhard Reutner-Fischer
>> <rep.dot.nop@gmail.com> wrote:
>>> On 17 April 2014 16:51:23 Konstantin Serebryany
>>> <konstantin.s.serebryany@gmail.com> wrote:
>>>
>>>> On Thu, Apr 17, 2014 at 6:27 PM, Bernhard Reutner-Fischer
>>>> <rep.dot.nop@gmail.com> wrote:
>>>> > On 17 April 2014 16:07, Konstantin Serebryany
>>>> > <konstantin.s.serebryany@gmail.com> wrote:
>>>> >> Hi,
>>>> >>
>>>> >> If you are trying to modify the libsanitizer files, please read here:
>>>> >> https://code.google.com/p/address-sanitizer/wiki/HowToContribute
>>>> >
>>>> > I read that, thanks. Patch 3/3 is for current compiler-rt git repo,
>>>> > please install it there, i do not have write access to the LLVM nor
>>>> > compiler-rt trees.
>>>>
>>>> I can commit your patch to llvm tree only after you follow the process
>>>> described on that page.
>>>> Sorry, this is a hard rule.
>>>
>>>
>>> What part of the process do you think I did not follow?
>>>
>>> I made a patch for compiler-rt, sent it to llvm-commits@cs.uiuc.edu then
>>> provided the corresponding GCC parts, along a backport of the new bits that
>>> I expect to be overwritten once you do a new merge, leaving just the GCC
>>> configuy bits. This is how I read the wiki page you cite.
>>>
>>> Please tell me what you expect me to do differently?
>>
>> First, I did not notice that you've sent it to llvm-commits because it
>> was also sent to the gcc list (unusual thing to happen)
>> and got filtered into the gcc part of my mail. Sorry.
>> But second, the patch is far from trivial and you should not expect us
>> to commit it w/o a careful review,
>> so here comes another part of the wiki: "For non-trivial patches
>> please use Phabricator -- this will help us reply faster."
>
> http://reviews.llvm.org/D3464
>
> thanks,