This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [DOC PATCH] Rewrite docs for inline asm


2014-04-14 14:24 GMT+08:00 dw <limegreensocks@yahoo.com>:
> Having resolved the objections, I'm posting the updated patch.  I don't have
> permissions to commit this patch, but I do have a release on file with the
> FSF.
>
>
> Problem description:
> The existing documentation does an inadequate job of describing gcc's
> implementation of the "asm" keyword.  This has led to a great deal of
> confusion as people struggle to understand how it works. This entire section
> requires a rewrite that provides a structured layout and detailed
> descriptions of each of the parameters along with examples.
>
> ChangeLog:
> 2014-04-03 David Wohlferd (LimeGreenSocks@yahoo.com)
>            Andrew Haley (aph@redhat.com)
>            Richard Sandiford (rdsandiford@googlemail.com)
>
>     * extend.texi: Completely rewrite inline asm section / reorg asm-related
> sections
>
> David Wohlferd

Hi, David,

A few nit picking about ChangeLog format:

  1. The "extend.texi" is supposed to have "doc/" prefix.
  2. 80-columns limit each line in the description.
  3. Better have '.' at the end of a sentence.

So, the refine description is suggested using:

        * doc/extend.texi: Completely rewrite inline asm section and reorg
        asm-related sections.


Hope your patch can be approved soon. :)


Best regards,
jasonwucj


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]