This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [COMMITTED] Fix silly error in aarch64_register_move_cost

From: Jeff Law <law at redhat dot com>
To: Richard Henderson <rth at redhat dot com>, GCC Patches <gcc-patches at gcc dot gnu dot org>
Cc: Marcus Shawcroft <marcus dot shawcroft at arm dot com>
Date: Fri, 18 Apr 2014 14:12:34 -0600
Subject: Re: [COMMITTED] Fix silly error in aarch64_register_move_cost
Authentication-results: sourceware.org; auth=none
References: <53514CA4 dot 3060704 at redhat dot com>

On 04/18/14 10:02, Richard Henderson wrote:

Building mainline I got

.../aarch64.c:4879:134: error: invalid conversion from âreg_class_t {aka int}â to âmachine_modeâ [-fpermissive]
    if (! TARGET_SIMD && GET_MODE_SIZE (from) == 128 && GET_MODE_SIZE (to) == 128)


Sure enough, TO and FROM are not modes.  Did mainline just change away from
permissive or something?  It surely seems like we ought to have seen this
earlier...

I haven't looked at GET_MODE_XXX, but most, if not of the RTL checkingis disabled because it's too expensive.

I'm hoping that David's work will take us to a place where we can domore static checking on the RTL bits too.


jeff

References:
- [COMMITTED] Fix silly error in aarch64_register_move_cost
  - From: Richard Henderson

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]