This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
RE: [PATCH v7?] PR middle-end/60281
- From: Bernd Edlinger <bernd dot edlinger at hotmail dot de>
- To: lin zuojian <manjian2006 at gmail dot com>
- Cc: "gcc-patches at gcc dot gnu dot org" <gcc-patches at gcc dot gnu dot org>, Ramana Radhakrishnan <ramana dot gcc at googlemail dot com>, Jakub Jelinek <jakub at redhat dot com>
- Date: Thu, 17 Apr 2014 21:20:08 +0200
- Subject: RE: [PATCH v7?] PR middle-end/60281
- Authentication-results: sourceware.org; auth=none
- References: <53104188 dot 2040303 at gmail dot com>,<53106F83 dot 30108 at gmail dot com>,<DUB129-W7567CB53370333209B55B6E48D0 at phx dot gbl>,<DUB129-W49645D142963E5A89A2C03E46B0 at phx dot gbl>,<20140408140746 dot GA3169 at lin-desktop>,<DUB129-W59848A21EAD7B66E9737CBE46A0 at phx dot gbl>,<20140409103852 dot GA15709 at ubuntu>,<DUB129-W55F24442FBE3890D820578E46A0 at phx dot gbl>,<20140409104756 dot GC15709 at ubuntu>,<20140410144705 dot GB3562 at lin-desktop>,<20140417142914 dot GA6011 at lin-desktop>
Hi Lin,
On Thu, 17 Apr 2014 22:29:14, Lin Zuojian wrote:
>
> Hi Bernd,
> I have my copyright mark signed and the process has completed. Now I
> am going to answer two more questions before my patch can be
> commited right?
>
> Did you copy any
> files or text written by someone else in these changes?”
>
> no
>
> [Which files have you changed so far, and which new files have you written
> so far?]
> gcc/asan.c
> gcc/ChangeLog
> gcc/cfgexpand.c
>
> Okay, you may review my patch again, if there is no problem, please
> commit it for me.
> --
> Regards
> lin zuojian
I am not sure if your patch was already "approved" by a global GCC reviewer.
That is however absolutely necessary before it can be committed.
I think it would be best to re-submit the latest version of your patch now,
and ask a global reviewer for approval.
The message should be sent to gcc-patches@gcc.gnu.org and contain the
following information in addition to the proposed patch itself and the
change-log entry:
a) On which target(s) did you boot-strap your patch?
b) Did you run the testsuite?
c) When you compare the test results with and without the patch, were there any regressions?
Regards
Bernd.