This is the mail archive of the mailing list for the GCC project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] [CLEANUP] Declare global functions before defining them

On Tue, Apr 15, 2014 at 7:33 PM, Patrick Palka <> wrote:
> On Tue, Apr 15, 2014 at 3:52 AM, Richard Biener
> <> wrote:
>> On Mon, Apr 14, 2014 at 4:52 PM, Patrick Palka <> wrote:
>>> Hi everyone,
>>> Many source files currently define a global function that is not
>>> previously declared within that source file because the source file did
>>> not include the appropriate header file that declares said function.
>>> This patch fixes a number of these occurrences by making sure to include
>>> the appropriate header file within the offending source files.
>>> Bootstrapped and regtested on x86_64-unknown-linux-gnu.
>> How did you find these?  (in the C bootstrap times -Wstrict-prototypes
>> did that)
>> Thanks,
>> Richard.
> Like with the other two patches, the changes in this patch address a
> subset of the warnings emitted by -Wmissing-declarations.  In this
> case the subset is "extern functions that are declared inside a header
> file but whose defining source file does not include said header
> file".

Ok.  Then we should enable -Wmissing-declarations to not regress here.

The patch is ok.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]