This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [build] Correctly detect native TLS support with 64-bit gas on Solaris/x86 (PR target/60817)


On Tue, Apr 15, 2014 at 5:21 PM, Rainer Orth
<ro@cebitec.uni-bielefeld.de> wrote:
> As reported in the PR, gcc/configure currently fails to detect native
> TLS support on x86_64-*-solaris2* with a 64-bit gas since it feeds it
> 32-bit TLS code.  I haden't noticed this so far since I've been using a
> 32-bit gas here (no idea why).
>
> The following patch fixes this by making sure 64-bit code is both used
> for 64-bit-default configurations and the necessary assembler flags
> passed.  I've chosen to merge the i?86 and x86_64 cases to avoid
> duplicating considerable amounts of code.  When using the native Solaris
> assembler, the relocs need to be in lower case as already done for
> 32-bit.
>
> Tested by configuring for x86_64-pc-solaris2.11 with 32-bit gas, 64-bit
> gas, /bin/as, i386-pc-solaris2.11 with 32-bit gas and /bin/as,
> x86_64-unknown-linux-gnu, and i686-unknown-linux-gnu and checking that
> native TLS support is detected correctly.
>
> Ok for mainline or should I rather bootstrap the change on a couple of
> those configurations?
>
> Thanks.
>         Rainer
>
>
> 2014-04-15  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
>
>         PR target/60817
>         * configure.ac (set_have_as_tls): Merge i[34567]86-*-* and
>         x86_64-*-* cases.
>         Pass necessary as flags on 64-bit Solaris/x86.
>         Use lowercase relocs for x86_64-*-*.
>         * configure: Regenerate.

OK.

Thanks,
Uros.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]