This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [C PATCH] Make attributes accept enum values (PR c/50459)

From: Jason Merrill <jason at redhat dot com>
To: Marek Polacek <polacek at redhat dot com>, GCC Patches <gcc-patches at gcc dot gnu dot org>
Cc: "Joseph S. Myers" <joseph at codesourcery dot com>, Marc Glisse <marc dot glisse at inria dot fr>
Date: Tue, 15 Apr 2014 09:59:10 -0400
Subject: Re: [C PATCH] Make attributes accept enum values (PR c/50459)
Authentication-results: sourceware.org; auth=none
References: <20140414151045 dot GA20332 at redhat dot com>

On 04/14/2014 11:10 AM, Marek Polacek wrote:

+  else if (TREE_CODE (val) == IDENTIFIER_NODE)
+    {
+      tree t = lookup_name (val);
+      if (t && TREE_CODE (t) == CONST_DECL)
+	return DECL_INITIAL (t);
+    }

I'm uncomfortable with this; we should have looked up any attributes inthe parser. Does the testsuite hit this code?


Jason

Follow-Ups:
- Re: [C PATCH] Make attributes accept enum values (PR c/50459)
  - From: Marek Polacek

References:
- [C PATCH] Make attributes accept enum values (PR c/50459)
  - From: Marek Polacek

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]