This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [C PATCH] Make attributes accept enum values (PR c/50459)


On 04/14/2014 11:10 AM, Marek Polacek wrote:
+  else if (TREE_CODE (val) == IDENTIFIER_NODE)
+    {
+      tree t = lookup_name (val);
+      if (t && TREE_CODE (t) == CONST_DECL)
+	return DECL_INITIAL (t);
+    }

I'm uncomfortable with this; we should have looked up any attributes in the parser. Does the testsuite hit this code?

Jason


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]