This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Add DW_AT_const_value as unsigned or int depending on type and value used.
- From: Cary Coutant <ccoutant at google dot com>
- To: Mark Wielaard <mjw at redhat dot com>
- Cc: gcc-patches <gcc-patches at gcc dot gnu dot org>, Tom Tromey <tromey at redhat dot com>, Jason Merrill <jason at redhat dot com>
- Date: Mon, 14 Apr 2014 14:55:52 -0700
- Subject: Re: [PATCH] Add DW_AT_const_value as unsigned or int depending on type and value used.
- Authentication-results: sourceware.org; auth=none
- References: <1395573430-21207-1-git-send-email-mjw at redhat dot com> <1397510723 dot 5633 dot 49 dot camel at bordewijk dot wildebeest dot org>
>> * dwarf2out.c (gen_enumeration_type_die): Add DW_AT_const_value
>> as unsigned or int depending on type and value used.
>
> Since stage 1 opened up I would like to request approval again to push
> this. Patch rebased to current master attached.
The discussion that led to that TODO is here:
http://gcc.gnu.org/ml/gcc-patches/2013-04/msg01086.html
In that thread, I suggested a reorganization of this piece of code
that would also take care of the wider-than-unsigned-hwi case.
Also note that size_of_die and value_format will still choose
DW_FORM_data[1248] for dw_val_class_unsigned_const in most cases.
Don't you really want to use DW_FORM_udata?
-cary