This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: RFA: Testsuite PATCH to add support for dlopen tests
- From: Hans-Peter Nilsson <hp at bitrange dot com>
- To: Jakub Jelinek <jakub at redhat dot com>
- Cc: ramrad01 at arm dot com, Steve Ellcey <sellcey at mips dot com>, Dominique Dhumieres <dominiq at lps dot ens dot fr>, gcc-patches <gcc-patches at gcc dot gnu dot org>, ro at cebitec dot uni-bielefeld dot de, Richard Biener <richard dot guenther at gmail dot com>, jason at redhat dot com
- Date: Mon, 14 Apr 2014 12:51:12 -0400 (EDT)
- Subject: Re: RFA: Testsuite PATCH to add support for dlopen tests
- Authentication-results: sourceware.org; auth=none
- References: <20140408081007 dot F25D5103 at mailhost dot lps dot ens dot fr> <1396978104 dot 6866 dot 27 dot camel at ubuntu-sellcey> <CAJA7tRaDbqvSzx31H+rWVXiaFKbBg5O3uZ3jeFPvZ=G6Lswbmw at mail dot gmail dot com> <20140411071828 dot GP1817 at tucnak dot redhat dot com> <alpine dot BSF dot 2 dot 02 dot 1404132113350 dot 60850 at arjuna dot pair dot com> <20140414062929 dot GJ1817 at tucnak dot redhat dot com>
On Mon, 14 Apr 2014, Jakub Jelinek wrote:
> On Sun, Apr 13, 2014 at 09:24:28PM -0400, Hans-Peter Nilsson wrote:
> > On Fri, 11 Apr 2014, Jakub Jelinek wrote:
> >
> > > On Thu, Apr 10, 2014 at 02:18:26PM +0100, Ramana Radhakrishnan wrote:
> > > > I see failures from last night on aarch64-none-elf and arm-none-eabi
> > > > (both bare-metal) configurations even after moving up to dejagnu
> > > > 1.5.1. If this can't be fixed easily should we consider reverting this
> > > > patch in the interest of getting sane test results on bare-metal
> > > > targets before the release ?
> > > >
> > > > Should we also update the prereqs page to say dejagnu 1.5.1 ?
> > > > (http://gcc.gnu.org/install/prerequisites.html)
> > >
> > > Jason has disabled the problematic test temporarily last night, can you
> > > please verify bare-metal cross-testing now works?
> >
> > I just noticed that I see this error, so the problem still
> > exists at r209347 (seen for cris-elf).
> >
> > (The FAILs are old and provided only for context; the ERRORs are
> > fatal.)
>
> Does say following patch make the problem go away?
Yes, it does, thanks. (Tested by patching with the revertion of
the revert, then observing with "make check-c++
'RUNTESTFLAGS=--target_board=cris-sim
RUNTESTFLAGS=dg.exp=dlclose1.C'" that I got:
=== g++ Summary ===
# of unsupported tests 3
and in g++.log that those tests were indeed the expected ones.)
> --- gcc/gcc/testsuite/g++.dg/dso/dlclose1.C 2014-04-11 10:33:22.552213377 +0200
> +++ gcc/gcc/testsuite/g++.dg/dso/dlclose1.C 2014-04-14 08:27:57.311138264 +0200
> @@ -1,7 +1,7 @@
> // PR c++/60731
> // { dg-do run { target { dlopen && disable-for-4.9 } } }
> // { dg-add-options dlopen }
> -// { dg-build-dso "dlclose1-dso.cc" }
> +// ( dg-build-dso "dlclose1-dso.cc" )
>
> #include <dlfcn.h>
> extern "C" void abort();
brgds, H-P