This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: Fixing PR60773
- From: Jakub Jelinek <jakub at redhat dot com>
- To: Cong Hou <congh at google dot com>
- Cc: GCC Patches <gcc-patches at gcc dot gnu dot org>, Richard Biener <rguenther at suse dot de>
- Date: Wed, 9 Apr 2014 07:29:55 +0200
- Subject: Re: Fixing PR60773
- Authentication-results: sourceware.org; auth=none
- References: <CAK=A3=2CDfbQWmySY-402wgs2Or96d2MUEk63PTJse-ebgKCkg at mail dot gmail dot com> <20140408070702 dot GY1817 at tucnak dot redhat dot com> <CAK=A3=2RthQ15-BzF1Y8YpkQOgyPV3ZYBWFArP3qNKieD_FSnw at mail dot gmail dot com>
- Reply-to: Jakub Jelinek <jakub at redhat dot com>
On Tue, Apr 08, 2014 at 07:40:09PM -0700, Cong Hou wrote:
> On Tue, Apr 8, 2014 at 12:07 AM, Jakub Jelinek <jakub@redhat.com> wrote:
> > On Mon, Apr 07, 2014 at 12:16:12PM -0700, Cong Hou wrote:
> >> --- a/gcc/testsuite/ChangeLog
> >> +++ b/gcc/testsuite/ChangeLog
> >> @@ -1,3 +1,11 @@
> >> +2014-04-07 Cong Hou <congh@google.com>
> >> +
> >> + PR testsuite/60773
> >> + * testsuite/lib/target-supports.exp:
> >> + Add check_effective_target_vect_widen_mult_si_to_di_pattern.
> >
> > No testsuite/ prefix here. Please write it as:
> > * lib/target-supports.exp
> > (check_effective_target_vect_widen_si_to_di_pattern): New.
>
> Thank you for pointing it out. Corrected.
Only partially, I see there just the #include removed and testsuite/
prefix removed, but not the using the style where in () is the name
of function that has been added/modified and after ): what has been done
with it.
Anyway, please commit it with the above proposed change, this is a P1
and thus urgent.
Thanks.
Jakub