This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: Fixing PR60773
- From: Jakub Jelinek <jakub at redhat dot com>
- To: Cong Hou <congh at google dot com>
- Cc: GCC Patches <gcc-patches at gcc dot gnu dot org>, Richard Biener <rguenther at suse dot de>
- Date: Tue, 8 Apr 2014 09:07:02 +0200
- Subject: Re: Fixing PR60773
- Authentication-results: sourceware.org; auth=none
- References: <CAK=A3=2CDfbQWmySY-402wgs2Or96d2MUEk63PTJse-ebgKCkg at mail dot gmail dot com>
- Reply-to: Jakub Jelinek <jakub at redhat dot com>
On Mon, Apr 07, 2014 at 12:16:12PM -0700, Cong Hou wrote:
> --- a/gcc/testsuite/ChangeLog
> +++ b/gcc/testsuite/ChangeLog
> @@ -1,3 +1,11 @@
> +2014-04-07 Cong Hou <congh@google.com>
> +
> + PR testsuite/60773
> + * testsuite/lib/target-supports.exp:
> + Add check_effective_target_vect_widen_mult_si_to_di_pattern.
No testsuite/ prefix here. Please write it as:
* lib/target-supports.exp
(check_effective_target_vect_widen_si_to_di_pattern): New.
> --- a/gcc/testsuite/gcc.dg/vect/pr60656.c
> +++ b/gcc/testsuite/gcc.dg/vect/pr60656.c
> @@ -1,5 +1,7 @@
> /* { dg-require-effective-target vect_int } */
> +/* { dg-require-effective-target vect_long } */
>
> +#include <stdarg.h>
I fail to see why you need this include, neither your test nor tree-vect.h
uses va_*.
Otherwise looks good to me.
Jakub