This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [C++] Weffc++/Wnon-virtual-dtor confusion
- From: Markus Trippelsdorf <markus at trippelsdorf dot de>
- To: Nathan Sidwell <nathan at acm dot org>
- Cc: Jason Merrill <jason at redhat dot com>, GCC Patches <gcc-patches at gcc dot gnu dot org>
- Date: Sun, 6 Apr 2014 11:50:33 +0200
- Subject: Re: [C++] Weffc++/Wnon-virtual-dtor confusion
- Authentication-results: sourceware.org; auth=none
- References: <533967BE dot 1020301 at acm dot org> <20140404163809 dot GA285 at x4> <533EE25D dot 9090406 at acm dot org> <20140404165430 dot GB285 at x4> <533EE635 dot 4090106 at acm dot org> <533EE9BB dot 2030202 at redhat dot com> <533EECEA dot 6040805 at acm dot org> <53410CB9 dot 6000704 at acm dot org>
On 2014.04.06 at 09:13 +0100, Nathan Sidwell wrote:
> On 04/04/14 18:33, Nathan Sidwell wrote:
>
> > I'm testing a patch that makes the test in the loop:
> >
> > if (TREE_PUBLIC (base_binfo)
>
> Hm, binfo's aren't noted that way, it's encoded in BINFO_ACCESS and
> SET_BINFO_ACCESS in search.c. We'd need to move those back to cp.h or expose an
> interface in search.c. This is looking like a rat hole ...
Thus a revert looks like the best option at this point.
--
Markus