This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [Patch, fortran] PR60717 - Wrong code with recursive procedure with unlimited polymorphic dummy argument


Le 02/04/2014 22:29, Paul Richard Thomas a écrit :
> Dear All,
> 
> This fix, of itself, is quite obvious.  The offset was being set to
> zero for array segments, rather than that required for unity valued
> lvalues.
> 
> I think that the fix could be used to clean up:
> 
> trans-expr.c(gfc_trans_alloc_subarray_assign)
> trans-expr.c(gfc_trans_pointer_assign)
> trans-expr.c(fncall_realloc_result)
> trans-array.c(trans_associate_var)
> 
> each of which contains calculation of the offset. However, I do not
> think that this is the stage to fix things that are not broken!
> 
> I propose to keep the PR open as a reminder to look into this.
> 
> Bootstrapped and regtested on X86_64/FC17 - OK for trunk and backporting to 4.8?
> 

Hello Paul,

this looks good; OK.  Thanks.

Mikael


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]