This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

RE: [PATCH][1/3] Fix PR54733 Optimize endian independent load/store


> From: Joseph Myers [mailto:joseph@codesourcery.com]
> 
> > +       if { [is-effective-target bswap]
> > +            && ![istarget x86_64-*-*] } {
> 
> That x86_64-*-* test is wrong.  x86_64-*-* and i?86-*-* should always be
> handled the same (if you then want to distinguish 32-bit and 64-bit
> multilibs, you check the appropriate effective-target there, depending on
> whether the condition is one on the ABI or which register size is being
> used, which affects how x32 should be counted).

Indeed, it's a mistake. I?86 should be in there two. Please find attached an updated patch.

Best regards,

Thomas 

Attachment: gcc32rm-84.3.1.part1.diff
Description: Binary data


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]