This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] S/390: Don't include 32 bit fp to int routines for 64 bit libgcc
- From: Andreas Krebbel <krebbel at linux dot vnet dot ibm dot com>
- To: Jakub Jelinek <jakub at redhat dot com>
- Cc: gcc-patches at gcc dot gnu dot org
- Date: Thu, 27 Mar 2014 16:32:19 +0100
- Subject: Re: [PATCH] S/390: Don't include 32 bit fp to int routines for 64 bit libgcc
- Authentication-results: sourceware.org; auth=none
- References: <20140327135904 dot GA2883 at bart> <20140327141528 dot GA1817 at tucnak dot redhat dot com>
On 27/03/14 15:15, Jakub Jelinek wrote:
> Does this fix the:
> -__fixdfti@@GCC_3.0 FUNC GLOBAL DEFAULT
> -__fixsfti@@GCC_3.0 FUNC GLOBAL DEFAULT
> -__fixtfti@@GCC_4.1.0 FUNC GLOBAL DEFAULT
> -__fixunsdfti@@GCC_3.0 FUNC GLOBAL DEFAULT
> -__fixunssfti@@GCC_3.0 FUNC GLOBAL DEFAULT
> -__fixunstfti@@GCC_4.1.0 FUNC GLOBAL DEFAULT
> regression when comparing
> readelf -Ws libgcc_s.so.1 | sed -n '/\.symtab/,$d;/ UND /d;/@GLIBC_PRIVATE/d;/\(GLOBAL\|WEAK\|UNIQUE\)/p' | awk '{ if ($4 == "OBJECT") { printf "%s %s %s %s %s\n", $8, $4, $5, $6, $3 } else { printf "%s %s %s %s\n", $8, $4, $5, $6 }}' | LC_ALL=C sort -u
> output between 4.8 and 4.9?
Yes. It does fix it.
>> #if defined(__x86_64__) || (!defined(__i386__) && defined(__LP64__)) \
>> - || defined(__mips64)
>> + || defined(__mips64) || defined(__s390x__)
>> host_address=64
>> #else
>> host_address=32
>
> Why is this needed? Don't s390x define __LP64__ ?
We do. I'll remove it.
Bye,
-Andreas-