This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Don't bootstrap libsanitizer or libvtv unless needed
- From: Jakub Jelinek <jakub at redhat dot com>
- To: Paolo Bonzini <bonzini at gnu dot org>
- Cc: DJ Delorie <dj at redhat dot com>, Alexandre Oliva <aoliva at redhat dot com>, Ralf Wildenhues <Ralf dot Wildenhues at gmx dot de>, Richard Biener <rguenther at suse dot de>, gcc-patches at gcc dot gnu dot org
- Date: Tue, 25 Mar 2014 17:38:40 +0100
- Subject: Re: [PATCH] Don't bootstrap libsanitizer or libvtv unless needed
- Authentication-results: sourceware.org; auth=none
- References: <20140320122450 dot GJ1817 at tucnak dot redhat dot com> <5331B0A6 dot 1050706 at gnu dot org>
- Reply-to: Jakub Jelinek <jakub at redhat dot com>
On Tue, Mar 25, 2014 at 05:36:54PM +0100, Paolo Bonzini wrote:
> Il 20/03/2014 13:24, Jakub Jelinek ha scritto:
> >We currently bootstrap both libsanitizer and libvtv, the former
> >just in case somebody decides to --with-build-config=bootstrap-asan
> >(or --with-build-config=bootstrap-ubsan), the latter if somebody decides
> >to --enable-vtable-verify.
> >
> >This patch changes it so that we only bootstrap libsanitizer if
> >bootstrap-asan or bootstrap-ubsan is in BOOT_CONFIG, and only bootstrap
> >libvtv if --enable-vtable-verify.
> >
> >Bootstrapped/regtested on x86_64-linux and i686-linux, on x86_64 it
> >saved a few minutes of build time, neither libsanitizer nor libvtv
> >has been bootstrapped, only built in stage3.
> >Currently also bootstrapping on i686-linux with
> >--enable-vtable-verify --with-build-config=bootstrap-asan
> >but already got into stage2 and verified that both libsanitizer and libvtv
> >are being bootstrapped in that case.
> >
> >Ok for trunk?
> >
> >2014-03-20 Jakub Jelinek <jakub@redhat.com>
> >
> > * configure.ac: Move BUILD_CONFIG set up earlier. Add
> > --enable-vtable-verify option parsing. Don't add
> > target-libsanitizer to bootstrap_target_libs unless
> > --with-build-config=bootstrap-asan or
> > --with-build-config=bootstrap-ubsan. Don't add target-libvtv
> > to bootstrap_target_libs unless --enable-vtable-verify.
> > * configure: Regenerated.
>
> Is the extra complication really worth saving a few minutes of compile time?
IMHO yes, saving around 5-10 minutes of x86_64 bootstraps that you perform
several times a day is worth it.
Jakub