Re: [PATCH][AARCH64]PR60034

[Kugan <kugan dot vivekanandarajah at linaro dot org>]

>> If I understand gcc/rtl.h correctly, SYMBOL_REF_ANCHOR_P (sym) is
>> required for anchor SYMBOL_REFS. SYMBOL_REF_BLOCK (sym) != NULL is
>> probably redundant. This can probably become an gcc_assert
>> (SYMBOL_REF_BLOCK (sym)) instead.
> 
> I agree with your interpretation of the code and comments in rtl.h.  I
> also accept that SYMBOL_REF_ANCHOR_P() is sufficient to resolve the
> test case.  However I'm wondering why we need to constraint the test
> down to SYMBOL_REF_ANCHOR_P().  At this point in the code we are
> trying to find alignment of the object, if we have a SYMBOL_REF_BLOCK
> then we can get the block alignment irrespective of
> SYMBOL_REF_ANCHOR_P().

Thanks for the explanation.  Is the attached patch looks OK ?

Thanks,
Kugan



gcc/

2014-03-25  Kugan Vivekanandarajah  <kuganv@linaro.org>

	PR target/60034
	* aarch64/aarch64.c (aarch64_classify_address): Fix alignment for
	section anchor.



gcc/testsuite/

2014-03-25  Kugan Vivekanandarajah  <kuganv@linaro.org>

	PR target/60034
	* gcc.target/aarch64/pr60034.c: New file.

Attachment: p.txt
Description: Text document