This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [committed] Skip gcc.dg/torture/pr60092.c on 32-bit hpux
- From: Rainer Orth <ro at CeBiTec dot Uni-Bielefeld dot DE>
- To: John David Anglin <dave dot anglin at bell dot net>
- Cc: GCC Patches <gcc-patches at gcc dot gnu dot org>
- Date: Mon, 24 Mar 2014 15:06:28 +0100
- Subject: Re: [committed] Skip gcc.dg/torture/pr60092.c on 32-bit hpux
- Authentication-results: sourceware.org; auth=none
- References: <BLU0-SMTP87780544A0C561E8250BFE977A0 at phx dot gbl> <yddbnwww0v8 dot fsf at CeBiTec dot Uni-Bielefeld dot DE> <BLU0-SMTP62BB8653535ABAC490F73977A0 at phx dot gbl>
John David Anglin <dave.anglin@bell.net> writes:
> On 3/24/2014 2:45 AM, Rainer Orth wrote:
>> John David Anglin <dave.anglin@bell.net> writes:
>>
>>> Index: gcc.dg/torture/pr60092.c
>>> ===================================================================
>>> --- gcc.dg/torture/pr60092.c (revision 208769)
>>> +++ gcc.dg/torture/pr60092.c (working copy)
>>> @@ -1,5 +1,6 @@
>>> /* { dg-do run } */
>>> /* { dg-require-weak "" } */
>>> +/* { dg-skip-if "No undefined weak" { hppa*-*-hpux* && { ! lp64 } } {
>>> "*" } { "" } } */
>> Please omit those default args to dg-skip-if. Besides, it seems we
>> should have a separate undefined_weak (or whatever) keyword for this,
>> rather than listing targets explicitly. But that's certainly not 4.9
>> material.
> I agree. I'll see about removing the default arguments. There are a bunch
> of tests
Thanks.
> with the same dg-skip-if statement.
I know. I mean to make a pass over the whole testsuite removing those
(now superfluous) default args. This stuff tends to be just copied
around, so it will resurface over and over again. Same for other stuff:
our testsuite is riddled with copy-and-paste programming ;-)
Rainer
--
-----------------------------------------------------------------------------
Rainer Orth, Center for Biotechnology, Bielefeld University