This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Fix g++.dg/opt/pr56999.C
- From: Jakub Jelinek <jakub at redhat dot com>
- To: John David Anglin <dave dot anglin at bell dot net>
- Cc: GCC Patches <gcc-patches at gcc dot gnu dot org>
- Date: Mon, 24 Mar 2014 07:21:05 +0100
- Subject: Re: [PATCH] Fix g++.dg/opt/pr56999.C
- Authentication-results: sourceware.org; auth=none
- References: <BLU0-SMTP19785315E7A6EFBF6E229B977A0 at phx dot gbl>
- Reply-to: Jakub Jelinek <jakub at redhat dot com>
On Sun, Mar 23, 2014 at 09:47:21PM -0400, John David Anglin wrote:
> On hppa64-hp-hpux11.11, the lack of a pragma to pop the currently
> hidden visibility before
> main results in main being hidden. The attached change adds a pop
> pragma to resolve the
> test failure:
> ld: (Warning) Potential unresolved symbol "main": shared library
> reference is resolved to non-exported definition in file "/var/tmp//
> ccUra9KR.o". FAIL: g++.dg/opt/pr56999.C -std=gnu++98 (test for
> excess errors)
> Tested on hppa2.0w-hp-hpux11.11 and hppa64-hp-hpux11.11.
>
> OK for trunk?
2014-03-23 John David Anglin <danglin@gcc.gnu.org>
PR testsuite/58013
* g++.dg/opt/pr56999.C: Pop hidden visibility.
Index: g++.dg/opt/pr56999.C
===================================================================
--- g++.dg/opt/pr56999.C (revision 208769)
+++ g++.dg/opt/pr56999.C (working copy)
@@ -159,6 +159,7 @@
pendingRecompiles->append (info);
}
volatile JITScript *JSScript::JITScriptHandle::UNJITTABLE;
+#pragma GCC visibility pop(hidden)
This must be
#pragma GCC visibility pop
Ok with that change (just verified the testcase is still miscompiled with that change
before Vlad's r198082 fix and works after it.
Jakub