This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Update the overall summary after edge_summary is updated
- From: Jan Hubicka <hubicka at ucw dot cz>
- To: Dehao Chen <dehao at google dot com>
- Cc: GCC Patches <gcc-patches at gcc dot gnu dot org>, David Li <davidxl at google dot com>, Luis Lozano <llozano at google dot com>, Jan Hubicka <hubicka at ucw dot cz>
- Date: Sun, 23 Mar 2014 02:32:37 +0100
- Subject: Re: [PATCH] Update the overall summary after edge_summary is updated
- Authentication-results: sourceware.org; auth=none
- References: <CAO2gOZW0X14Vt6t9aTeASRpHNHqjpA2BygU1z1saaN1LkjVFKA at mail dot gmail dot com>
> Hi,
>
> This patch updates node's inline summary after edge_summary is
> updated. Otherwise it could lead to incorrect inline summary.
>
> Bootstrapped and gcc regression test on-going.
>
> OK for trunk?
>
> Thanks,
> Dehao
>
> gcc/ChangeLog:
>
> 2014-03-21 Dehao Chen <dehao@google.com>
>
> *ipa-inline.c (early_inliner): updates overall summary.
Looks resonable, do you have testcase where it would make a difference?
Honza
>
> Index: gcc/ipa-inline.c
> ===================================================================
> --- gcc/ipa-inline.c (revision 208755)
> +++ gcc/ipa-inline.c (working copy)
> @@ -2318,6 +2318,7 @@ early_inliner (void)
> edge->call_stmt, edge->callee->decl, false))
> edge->call_stmt_cannot_inline_p = true;
> }
> + inline_update_overall_summary (node);
> timevar_pop (TV_INTEGRATION);
> iterations++;
> inlined = false;