This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH 2/2, AARCH64] Test case changes: Re: [RFC] [PATCH, AARCH64] : Using standard patterns for stack protection.
- From: Marcus Shawcroft <marcus dot shawcroft at gmail dot com>
- To: Venkataramanan Kumar <venkataramanan dot kumar at linaro dot org>
- Cc: "gcc-patches at gcc dot gnu dot org" <gcc-patches at gcc dot gnu dot org>, Patch Tracking <patch at linaro dot org>
- Date: Wed, 19 Mar 2014 17:58:09 +0000
- Subject: Re: [PATCH 2/2, AARCH64] Test case changes: Re: [RFC] [PATCH, AARCH64] : Using standard patterns for stack protection.
- Authentication-results: sourceware.org; auth=none
- References: <CAJK_mQ28gbxAC__6pE0LRqBQtZMzsrkg74z7cP0+hG_e+OR1Jg at mail dot gmail dot com>
On 19 March 2014 17:18, Venkataramanan Kumar
<venkataramanan.kumar@linaro.org> wrote:
> I used the existing dg-require-effective-target check,
> "stack_protector" and added it in a separate line.
>
> ChangeLog.
>
> 2014-03-19 Venkataramanan Kumar <venkataramanan.kumar@linaro.org>
> * g++.dg/fstack-protector-strong.C: Add effetive target check for
> stack protection.
> * gcc.dg/fstack-protector-strong.c: Likewise.
>
> These two tests are passing now for aarch64-none-linux-gnu target under QEMU.
Venkat,
I think this change is reasonable (for stage-1) but I'd like one of
the testsuite maintainers to ACK the change.
Cheers
/Marcus