This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [patch testsuite]: Fix some mingw testcases in gcc.dg
- From: Kai Tietz <ktietz70 at googlemail dot com>
- To: Rainer Orth <ro at cebitec dot uni-bielefeld dot de>
- Cc: GCC Patches <gcc-patches at gcc dot gnu dot org>
- Date: Mon, 17 Mar 2014 21:54:25 +0100
- Subject: Re: [patch testsuite]: Fix some mingw testcases in gcc.dg
- Authentication-results: sourceware.org; auth=none
- References: <CAEwic4bPWvDS6rs8gVoxFGo-UwKv8-p75+erHy3d+SFa-sbYQg at mail dot gmail dot com> <yddiorch7n2 dot fsf at CeBiTec dot Uni-Bielefeld dot DE>
2014-03-17 21:50 GMT+01:00 Rainer Orth <ro@cebitec.uni-bielefeld.de>:
> Hi Kai,
>
>> this patch fixes some regressions introduced by default-option
>> -fms-extensions for mingw-targets.
>
> you should state in your submissions *which* regressions were
> introduced/*which* problem you are fixing. While this may be obvious to
> you, it's often not so to reviewers.
I did. "The regressions in testsuite are introduced by turning on the
state of -fms-extensions." That all, and not more to tell.
>> ChangeLog
>>
>> 2014-03-17 Kai Tietz <ktietz@redhat.com>
>>
>> * anon-struct-1.c: Add -fno-ms-extensions option for mingw targets.
>> * anon-struct-11.c: Likewise.
>> * anon-struct-2.c: Likewise.
>> * c11-anon-struct-2.c: Likewise.
>> * c11-anon-struct-3.c: Likewise.
>
> gcc.dg/ prefix missing in ChangeLog entries.
>
>> Tested for i686-w64-mingw32, and x86_64-unknown-linux-gnu. Ok for apply?
>
> Ok with that change.
>
> Rainer
>
> --
> -----------------------------------------------------------------------------
> Rainer Orth, Center for Biotechnology, Bielefeld University