This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[PATCH,GCC/Thumb1] Correctly reset the variable after_arm_reorg for Thumb1 target


Hi,

I am working on another patch and found this per-function variable isn't
correctly reset for Thumb1 target. Currently no ICE will be triggered
because we don't call function arm_split_constants for Thumb1 target. This
patch intends to define this variable in machine_function struct in arm.h.
In this way, the variable will be correctly reset and ready for being used
for Thumb1 target in future.

Tested with gcc regression test for Thumb1 target cortex-m0. No new
regressions.

Is it ok to trunk?

BR,
Terry

2014-03-17  Terry Guo  <terry.guo@arm.com>

        * config/arm/arm.h (machine_function): Define variable
after_arm_reorg here.
        * config/arm/arm.c (after_arm_reorg): Remove the definition.
        (arm_split_constant): Update the way to access variable
after_arm_reorg.
        (arm_reorg): Ditto.
        (arm_output_function_epilogue): Remove the reset of after_arm_reorg.

Attachment: reset-after_arm_reorg-thumb1-v3.txt
Description: Text document


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]