This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Fix up #pragma weak handling (PR middle-end/36282)
- From: "Joseph S. Myers" <joseph at codesourcery dot com>
- To: Jakub Jelinek <jakub at redhat dot com>
- Cc: Jan Hubicka <hubicka at ucw dot cz>, <gcc-patches at gcc dot gnu dot org>
- Date: Thu, 13 Mar 2014 20:53:25 +0000
- Subject: Re: [PATCH] Fix up #pragma weak handling (PR middle-end/36282)
- Authentication-results: sourceware.org; auth=none
- References: <20140313180042 dot GZ22862 at tucnak dot redhat dot com>
On Thu, 13 Mar 2014, Jakub Jelinek wrote:
> 2014-03-13 Jakub Jelinek <jakub@redhat.com>
>
> PR middle-end/36282
> * c-pragma.c (apply_pragma_weak): Only look at
> TREE_SYMBOL_REFERENCED (DECL_ASSEMBLER_NAME (decl)) if
> DECL_ASSEMBLER_NAME_SET_P (decl).
> (maybe_apply_pending_pragma_weaks): Exit early if
> vec_safe_is_empty (pending_weaks) rather than only when
> !pending_weaks.
> (maybe_apply_pragma_weak): Likewise. If !DECL_ASSEMBLER_NAME_SET_P,
> set assembler name back to NULL afterwards.
>
> * c-c++-common/pr36282-1.c: New test.
> * c-c++-common/pr36282-2.c: New test.
> * c-c++-common/pr36282-3.c: New test.
> * c-c++-common/pr36282-4.c: New test.
OK.
--
Joseph S. Myers
joseph@codesourcery.com