This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH, PR58066] preferred_stack_boundary update for tls expanded call
- From: "H.J. Lu" <hjl dot tools at gmail dot com>
- To: Wei Mi <wmi at google dot com>
- Cc: GCC Patches <gcc-patches at gcc dot gnu dot org>, David Li <davidxl at google dot com>, Uros Bizjak <ubizjak at gmail dot com>
- Date: Wed, 12 Mar 2014 14:07:15 -0700
- Subject: Re: [PATCH, PR58066] preferred_stack_boundary update for tls expanded call
- Authentication-results: sourceware.org; auth=none
- References: <CA+4CFy5BdB2=mnd=o+8GmQ5EBtJfGUFB-0AKFou2xMHvekCAJw at mail dot gmail dot com> <CAMe9rOrrF5zTYh6=KoKcmNDZYi_oirh6SNC+_JdCY4U6NpBMTQ at mail dot gmail dot com> <CA+4CFy7SHAHmEmreq+GsTzA9nYnWiSG_Fut_fs16BnFH+LOQow at mail dot gmail dot com> <CAMe9rOpG8N8YPA=dHMDq7fL6Kyn1PU1-RrD6bqBjHFUOfz7n9Q at mail dot gmail dot com> <CA+4CFy79py1XrgDygpRg9j4ZLz9waKMKkoAvvA_QnN6M7usCaA at mail dot gmail dot com>
On Wed, Mar 12, 2014 at 2:03 PM, Wei Mi <wmi@google.com> wrote:
>> There are several problems with this:
>>
>> 1. It doesn't work with C.
>
> Ok, I will change the testcase using C.
>
>> 2. IA32 has the same issue and isn't fixed.
>
> I thought IA32 didn't have the same issue because abi only requires 32
> bit alignment for stack starting address.
>
> oh, I found the old patch
> http://gcc.gnu.org/ml/gcc-patches/2006-09/msg00298.html which changed
> the default alignment to 128bit. Ok, will remove the TARGET_64BIT
> constraint.
>
>> 3. There is no testcase for global dynamic model.
>>
>> --
>> H.J.
>
> Will add the testcase.
>
I posted a different patch in
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=58066
--
H.J.