This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [build, libgcc] Don't install vtv_*.o unless --enable-vtable-verify (PR libgcc/59339)
- From: Richard Biener <richard dot guenther at gmail dot com>
- To: Paolo Bonzini <bonzini at gnu dot org>
- Cc: Rainer Orth <ro at cebitec dot uni-bielefeld dot de>, GCC Patches <gcc-patches at gcc dot gnu dot org>, Ian Lance Taylor <iant at google dot com>
- Date: Thu, 6 Mar 2014 13:54:12 +0100
- Subject: Re: [build, libgcc] Don't install vtv_*.o unless --enable-vtable-verify (PR libgcc/59339)
- Authentication-results: sourceware.org; auth=none
- References: <yddha7bwngw dot fsf at lokon dot CeBiTec dot Uni-Bielefeld dot DE> <53186656 dot 8080802 at gnu dot org>
On Thu, Mar 6, 2014 at 1:13 PM, Paolo Bonzini <bonzini@gnu.org> wrote:
> Il 06/03/2014 12:55, Rainer Orth ha scritto:
>
>> Uros pointed me at PR libgcc/59339 where make install tries to install
>> the vtv_*.o files even if they aren't built, leading to install
>> warnings.
>>
>> The following patch fixes this by ensuring that the files are only
>> installed if built.
>>
>> Tested with make install in libgcc on x86-64-unknown-linux-gnu
>> --enable-vtable-verify (files are installed) and i686-unknown-linux-gnu
>> (no installation attempted).
>>
>> Ok for mainline?
>>
>> Rainer
>>
>>
>> 2014-03-06 Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
>>
>> PR libgcc/59339
>> * config.host (*-*-linux*, frv-*-*linux*, *-*-kfreebsd*-gnu)
>> (*-*-knetbsd*-gnu, *-*-gnu*, *-*-kopensolaris*-gnu): Only add
>> vtv_*.o to extra_parts if enable_vtable_verify.
>>
>>
>>
>>
>
> Ok.
I wondered why we build libvtv when --enable-vtable-verify is not
enabled. IMHO that doesn't make sense as you can't use it
anyway because the start files vtv_*.o are neither built nor
installed.
Richard.
> Paolo