This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH v7] PR middle-end/60281
- From: lin zuojian <manjian2006 at gmail dot com>
- To: Jakub Jelinek <jakub at redhat dot com>
- Cc: ramrad01 at arm dot com, gcc-patches <gcc-patches at gcc dot gnu dot org>
- Date: Tue, 4 Mar 2014 17:19:50 +0800
- Subject: Re: [PATCH v7] PR middle-end/60281
- Authentication-results: sourceware.org; auth=none
- References: <20140303085120 dot GB11890 at ubuntu> <20140303085859 dot GB22862 at tucnak dot redhat dot com> <20140303090946 dot GA10357 at ubuntu> <20140303131028 dot GG10357 at ubuntu> <20140303132355 dot GF22862 at tucnak dot redhat dot com> <20140304030202 dot GA8019 at ubuntu> <20140304031145 dot GB8019 at ubuntu> <20140304080456 dot GN22862 at tucnak dot redhat dot com> <20140304084456 dot GD15564 at ubuntu> <20140304091531 dot GP22862 at tucnak dot redhat dot com>
Thanks Jakub
--
Regards
lin zuojian
On Tue, Mar 04, 2014 at 10:15:31AM +0100, Jakub Jelinek wrote:
> On Tue, Mar 04, 2014 at 04:44:57PM +0800, lin zuojian wrote:
> > On Tue, Mar 04, 2014 at 09:04:56AM +0100, Jakub Jelinek wrote:
> > > On Tue, Mar 04, 2014 at 11:11:45AM +0800, lin zuojian wrote:
> > > > Without aligning the asan stack base,this base will only 64-bit aligned in ARM machines.
> > > > But asan require 256-bit aligned base because of this:
> > > > 1.right shift take ASAN_SHADOW_SHIFT(which is 3) bits are zeros
> > > > 2.store multiple/load multiple instructions require the other 2 bits are zeros
> > > >
> > > > that add up lowest 5 bits should be zeros.That means 32 bytes or 256 bits aligned.
> > > >
> > > > * asan.c (asan_emit_stack_protection): Force the base to align to
> > > > appropriate bits if STRICT_ALIGNMENT. Set shadow_mem align to
> > > > appropriate bits if STRICT_ALIGNMENT.
> > > > * cfgexpand.c (expand_stack_vars): Set base_align appropriately
> > > > when asan is on.
> > > > (expand_used_vars): Leave a space in the stack frame for alignment if
> > > > STRICT_ALIGNMENT.
> > >
> > > There were still a couple of formatting issues, I've fixed them below.
> > > Now, do you have a GCC copyright assignment or are under copyright
> > > assignment of some company working on GCC (ARM?)?
> > Thanks for the fixing!.
> > I have none of them.I have read the website,but don't know what exactly
> > I am expecting to do.
>
> Please follow
> http://git.savannah.gnu.org/cgit/gnulib.git/plain/doc/Copyright/request-assign.future
>
> Jakub