This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [C PATCH] remove goto in c_parser_sizeof_expression
- From: Marek Polacek <polacek at redhat dot com>
- To: Prathamesh Kulkarni <bilbotheelffriend at gmail dot com>
- Cc: gcc-patches at gcc dot gnu dot org, "Joseph S. Myers" <joseph at codesourcery dot com>
- Date: Mon, 24 Feb 2014 18:58:53 +0100
- Subject: Re: [C PATCH] remove goto in c_parser_sizeof_expression
- Authentication-results: sourceware.org; auth=none
- References: <CAJXstsCHg_Sh=G2rOQ5oKz+-dXBzYY_y0n2tad7mRoq6BsujfQ at mail dot gmail dot com> <20140222181444 dot GJ10901 at redhat dot com> <CAJXstsDRb_1Vj7XUtEpfmNkKxAFc0xW7SsFW0oxm7GAm_jX+DQ at mail dot gmail dot com> <20140222194827 dot GK10901 at redhat dot com> <CAJXstsBLdYg59RteokN4ULqYjOgq-W6cHx6VVwFoND7YnfCswQ at mail dot gmail dot com>
On Mon, Feb 24, 2014 at 11:08:27PM +0530, Prathamesh Kulkarni wrote:
> I apologize for bothering with stupid mistakes.
No problem, it takes some time to get up to speed.
> + mark_exp_read (expr.value);
> + if (TREE_CODE (expr.value) == COMPONENT_REF
> + && DECL_C_BIT_FIELD (TREE_OPERAND (expr.value, 1)))
> + error_at (expr_loc, "%<sizeof%> applied to a bit-field");
> + return c_expr_sizeof_expr (expr_loc, expr);
> }
This still doesn't seem quite right. As I said:
> > And this should be
> > if (TREE_CODE (expr.value) == COMPONENT_REF
> > && DECL_C_BIT_FIELD (TREE_OPERAND (expr.value, 1)))
> > error_at (expr_loc, "%<sizeof%> applied to a bit-field");
> > return c_expr_sizeof_expr (expr_loc, expr);
> >
That is, no tab before error_at (...), but four spaces.
(Of course there's no need to retest the patch when making such
trivial adjustments.)
Marek