This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Fix ix86_vectorize_vec_perm_const_ok (PR target/57896)
- From: Richard Henderson <rth at redhat dot com>
- To: Jakub Jelinek <jakub at redhat dot com>
- Cc: Uros Bizjak <ubizjak at gmail dot com>, gcc-patches at gcc dot gnu dot org
- Date: Thu, 20 Feb 2014 15:07:15 -0600
- Subject: Re: [PATCH] Fix ix86_vectorize_vec_perm_const_ok (PR target/57896)
- Authentication-results: sourceware.org; auth=none
- References: <20140220183933 dot GN22862 at tucnak dot redhat dot com> <53066862 dot 7060302 at redhat dot com> <20140220205929 dot GQ22862 at tucnak dot redhat dot com>
On 02/20/2014 02:59 PM, Jakub Jelinek wrote:
> ... so all we care about is that
> target/op0/op1 have the right modes and that target is a different register
> from op0 and op0 either the same as op1 or yet another register.
That's my point: yet another register. Thus the creation of a brand new pseudo
(or brand new dummy) is not irrelevant to the match.
>
> The problem I see with this is that we'll need to maintain test_regno
> everywhere. E.g. there are places which even fir !d->testing_p create
> temporary structures and set testing_p in it, that would now require
> that we also set test_regno there to something (what?).
True, I didn't think of the other places we set testing_p. But that's just one
or two more places to set test_regno. Not out of the question...
r~