This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH][RFC][libatomic] Override -mcpu option for arm linux ifunc targets


Ping?
http://gcc.gnu.org/ml/gcc-patches/2014-02/msg00069.html

On 03/02/14 11:50, Kyrill Tkachov wrote:
Hi all,

There is a slight issue with the libatomic Makefile for arm linux ifunc targets.
It adds an explicity -march=armv7-a option to the command line to enable
building the exclusive instruction variants in libatomic. However, if the
multilib machinery tries to add an -mcpu option that conflicts with the -march
one (such as -mcpu=cortex-a15) gcc will give a warning about incompatible -march
and -mcpu options, causing the -Werror build to fail.

A workaround here is to override the -mcpu option as well as the -march one.
This patch does that by adding an EXTRA_OVERRIDE variable and setting it to
-mcpu=cortex-a9 under the same conditions as when -march=armv7-a is selected, so
that it's added only when -march=armv70a is added.

Can someone see a better way of achieving this?

If this is acceptable, ok to commit?

Build and test arm-none-linux-gnueabi with --enable-gnu-indirect-function
Bootstrap on x86 with --enable-gnu-indirect-function

Thanks,
Kyrill

2014-02-03  Kyrylo Tkachov  <kyrylo.tkachov@arm.com>

      * Makefile.in: Override -mcpu option when building arm
      linux ifunc targets.



Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]