This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PING]Re: [PATCH][ARM]fix potential testsuite/gcc.target/arm/fixed_float_conversion.c regression


On 11/02/14 17:47, H.J. Lu wrote:
On Tue, Feb 11, 2014 at 9:46 AM, H.J. Lu <hjl.tools@gmail.com> wrote:
On Mon, Feb 10, 2014 at 6:02 AM, Renlin Li <renlin.li@arm.com> wrote:
On 03/02/14 15:56, Renlin Li wrote:
Hi all,

This patch will ensure testsuite/gcc.target/arm/fixed_float_conversion.c
is checked only when "-mfpu=vfp3 -mfloat-abi=softfp" is applicable for the
target.

Accordingly, two procs (check_effective_target_arm_vfp3_ok and
add_options_for_arm_vfp3) are added into
gcc/testsuite/lib/target-supports.exp.

I have also update related documentation.

Okay for trunk?

Kind regards,
Renlin Li


gcc/testsuite/ChangeLog:

2014-02-03  Renlin Li  <Renlin.Li@arm.com>

     * gcc.target/arm/fixed_float_conversion.c: Add arm_vfp3 option to the
test case.
     * lib/target-supports.exp: check_effective_target_arm_vfp3_ok: New.
     add_options_for_arm_vfp3: New.


gcc/ChangeLog:

2014-02-03  Renlin Li  <Renlin.Li@arm.com>

     * doc/sourcebuild.texi: Document check_effective_target_arm_vfp3_ok
and
     add_options_for_arm_vfp3

Hi,

Anybody help me to review this patch?

This breaks bootstrap:

../../src-trunk/gcc/doc/sourcebuild.texi:1963: @ref reference to
nonexistent node `arm_vfp3_ok'

I am checking in this as an obvious fix.


--
H.J.
--
diff --git a/gcc/doc/sourcebuild.texi b/gcc/doc/sourcebuild.texi
index 1ea5753..85ef819 100644
--- a/gcc/doc/sourcebuild.texi
+++ b/gcc/doc/sourcebuild.texi
@@ -1552,6 +1552,7 @@ ARM target supports @code{-mfpu=vfp -mfloat-abi=softfp}.
  Some multilibs may be incompatible with these options.

  @item arm_vfp3_ok
+@anchor{arm_vfp3_ok}
  ARM target supports @code{-mfpu=vfp3 -mfloat-abi=softfp}.
  Some multilibs may be incompatible with these options.
It has been fixed by Uros.


Hi Uros & H.J. ,

Thank you for the fix!
It's definitely my fault without double checking the patch.

Kind regards,
Renlin


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]