This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: print quotes around )
- From: "Joseph S. Myers" <joseph at codesourcery dot com>
- To: Prathamesh Kulkarni <bilbotheelffriend at gmail dot com>
- Cc: <gcc-patches at gcc dot gnu dot org>
- Date: Tue, 11 Feb 2014 00:05:09 +0000
- Subject: Re: print quotes around )
- Authentication-results: sourceware.org; auth=none
- References: <CAJXstsD-M2HdjWZFGxWR=bt+UDgEVa7jrsb9aMrpzUm9=Yw35Q at mail dot gmail dot com> <CAJXstsDN-MOx97TkqvOb6_kjAfXJnzvEvb1e4Kp3BMijq7KgQw at mail dot gmail dot com>
On Sun, 9 Feb 2014, Prathamesh Kulkarni wrote:
> On Sun, Feb 9, 2014 at 8:31 PM, Prathamesh Kulkarni
> <bilbotheelffriend@gmail.com> wrote:
> > A trivial fix to print quotes around ) in libcpp/macro.c
> > OK for trunk ?
> Will not work for if pfile->cb.error callback does not recognize %< and %>
> (maybe clients other than c, c++ front-ends ?).
> So we cannot include %< and %> in the error message ?
Certainly not while the callback is declared ATTRIBUTE_FPTR_PRINTF, I'd
have expected the bootstrap to fail with -Werror warnings.... (Declaring
the callback to allow GCC-internal formats might have corresponding
requirements for particular types to be declared first, where the
format-checking machinery knows how GCC-internal formats use GCC-internal
typedefs; you'd need to check.)
--
Joseph S. Myers
joseph@codesourcery.com