This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [C++ Patch] PR 58846

From: Paolo Carlini <paolo dot carlini at oracle dot com>
To: Rainer Orth <ro at CeBiTec dot Uni-Bielefeld dot DE>
Cc: "gcc-patches at gcc dot gnu dot org" <gcc-patches at gcc dot gnu dot org>, Jason Merrill <jason at redhat dot com>
Date: Tue, 04 Feb 2014 11:17:44 +0100
Subject: Re: [C++ Patch] PR 58846
Authentication-results: sourceware.org; auth=none
References: <52E91B33 dot 8040703 at oracle dot com> <yddy51r5hj0 dot fsf at lokon dot CeBiTec dot Uni-Bielefeld dot DE>

Hi,

On 02/04/2014 10:55 AM, Rainer Orth wrote:

Paolo Carlini <paolo.carlini@oracle.com> writes:

a very minor ICE on invalid regression, but since we explicitly allow for
redeclarations (also see comments in declare_global_var) we may as well
avoid crashing, at least in mainline. Tested x86_64-linux.

The test FAILs on Solaris which doesn't have __cxa_atexit:

FAIL: g++.dg/init/dso_handle2.C -std=c++98  (test for errors, line 10)
FAIL: g++.dg/init/dso_handle2.C -std=c++11  (test for errors, line 10)

Fixed like dso_handle1.C does by forcing -fuse-cxa-atexit.

Tested with the appropriate runtest invocations on i386-pc-solaris2.11
and x86_64-unknown-linux-gnu.  Ok for mainline?

I think it qualifies at obvious. Thanks!

Paolo.

PS: At some point I had it, when I adapted the testcase from an existingone, then I tried to minimize it ;-/

References:
- Re: [C++ Patch] PR 58846
  - From: Rainer Orth

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]