Re: [google gcc-4_8] gcov-tool: some new LIPO supports.

[Rong Xu <xur at google dot com>]

Comments are inlined. New patch attached to this email.

-Rong

On Thu, Jan 30, 2014 at 12:39 PM, Xinliang David Li <davidxl@google.com> wrote:
> On Wed, Jan 29, 2014 at 4:24 PM, Rong Xu <xur@google.com> wrote:
>> Hi,
>>
>> The attached patch adds some new features to gcov-tool. It aims to
>> rewrite LIPO profile for reuse, debug or performance tuning purpose.
>>
>> -l, --modu_list <file>              Only use the modules in this file
>
> I think in verbose mode, the tool should emit warnings when a module
> is trimmed due to this option. This can be used in regression test.
>

In previous patch, this warning is emitted unconventionally (not
guarded by verbose flag).
I changed it to under verbose mode in this patch.

>> -r, --string                             Replace string in path
>
> --path_substr_replace or something in that line.
>

Done.

>> -u, --use_imports_file             Use the grouping in import files.
>>
>
> Is there a path in code to auto test this?

As we discussed offline. This can be verified by a separated script.

>
>> -l uses only the modules in specified file to compute module grouping
>> (and subsequent dumping).
>> -r replaces the pattern specified in the argument. The format is:
>> old_str1:new_str1[,old_str2:new_str2]*, only the first occurrence is
>> replaced.
>> -u skips the run-time module grouping computation and reuses the one
>> comes with the profiles (which is user editable).
>>
>> Tested with profiles from google internal benchmarks.
>>
>
> Also use strcasestr for case insenstive operation.

Done.

>
> David
>
>> -Rong

Attachment: lipo_gcov_tool_patch2.txt
Description: Text document