This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.
Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
---|---|---|
Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |
Other format: | [Raw text] |
On 01/22/14 02:50, David Holsgrove wrote:
Hi Michael, On 22 January 2014 13:43, David Holsgrove <david.holsgrove@xilinx.com> wrote:-----Original Message----- From: Michael Eager [mailto:eager@eagerm.com] Sent: Friday, 17 January 2014 4:36 am To: David Holsgrove; gcc-patches@gcc.gnu.org Cc: Edgar Iglesias; John Williams; Vidhumouli Hunsigida; Nagaraju Mekala Subject: Re: [Patch, microblaze]: Fix ICE with mhard-float On 11/25/13 23:50, David Holsgrove wrote:Hi Michael, I've attached the same patch based on latest gcc master. Can this be applied to gcc-4_8-branch also. thanks, David On 15 July 2013 14:53, David Holsgrove <david.holsgrove@xilinx.com> wrote:Add SImode to cstoresf4's comparison operator, prevents ICE during combine rtl pass with error message; internal compiler error: in simplify_subreg, at simplify-rtx.c:5725 Use ordered_comparison_operator predicate to limit operators to those fcmp can handle, and letting compiler reorder insns to accommodate unordered as necessary. Changelog entry; 2013-07-15 David Holsgrove <david.holsgrove@xilinx.com> * gcc/config/microblaze/microblaze.md: Fix cstoresf4 and cbranchsf4 Can this be backported to gcc-4_8-branch also?Hi David -- You mention that this patch fixes an ICE. Is there a failing test case in the GCC Test Suite? Is there a GCC PR for this ICE? If not, please add a test case to the patch.Hi Michael, Thanks for the reply. No, unfortunately there isnât an existing test case which shows this ICE. I'm in the process of trying to recreate and distil into a small test case if possible, but the error was encountered whilst building a rather large app using microblaze linux.I've attached updated patch which includes a test case to check for this ICE. Tested on microblaze baremetal and microblazeel linux toolchains with / without my change. Updated ChangeLogs would be; gcc/ChangeLog 2014-01-22 David Holsgrove <david.holsgrove@xilinx.com> * config/microblaze/microblaze.md(cstoresf4, cbranchsf4): Replace comparison_operator with ordered_comparison_operator. testsuite/ChangeLog 2014-01-22 David holsgrove <david.holsgrove@xilinx.com> * testsuite/gcc.target/microblaze/isa/fcmp4.c: New file. thanks, David
mainline: Committed revision 207311. gcc-4_8-branch: Committed revision 207313. -- Michael Eager eager@eagercon.com 1960 Park Blvd., Palo Alto, CA 94306 650-325-8077
Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
---|---|---|
Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |